Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Stabilize spacetime server subcommands #1845

Merged
merged 25 commits into from
Oct 17, 2024
Merged

CLI - Stabilize spacetime server subcommands #1845

merged 25 commits into from
Oct 17, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Oct 11, 2024

Description of Changes

  • Made the server argument anonymous
  • Named the url arg on spacetime server add
  • Replaced --host and --protocol params with --url

API and ABI breaking changes

Yes, this breaks the spacetime server subcommand APIs.

Expected complexity level and risk

1

Testing

  • Updated existing smoketests

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior release-1.0 api-break A PR that breaks some user-visible API labels Oct 11, 2024
@bfops bfops marked this pull request as ready for review October 11, 2024 17:50
smoketests/tests/servers.py Outdated Show resolved Hide resolved
@bfops bfops changed the base branch from master to bfops/fix-server-edit October 17, 2024 19:14
@bfops bfops changed the base branch from bfops/fix-server-edit to master October 17, 2024 21:42
@bfops bfops enabled auto-merge October 17, 2024 21:43
@bfops bfops added this pull request to the merge queue Oct 17, 2024
@bfops bfops removed this pull request from the merge queue due to a manual request Oct 17, 2024
@bfops bfops added this pull request to the merge queue Oct 17, 2024
@bfops
Copy link
Collaborator Author

bfops commented Oct 17, 2024

(I just wanted to check that Internal tests had passed first)

Merged via the queue into master with commit 70ab143 Oct 17, 2024
8 checks passed
@bfops bfops deleted the bfops/cli-server branch October 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that breaks some user-visible API CLI only This change only affects the CLI behavior release-1.0 release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants